Remove 2018 deprecated runtime contenttype extension point#1644
Remove 2018 deprecated runtime contenttype extension point#1644vogella wants to merge 2 commits into
Conversation
Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit. |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
|
Awesome @HannesWell that works. Thank you for the tip |
Will do. |
Test Results 54 files ±0 54 suites ±0 35m 1s ⏱️ - 1m 28s For more details on these failures, see this check. Results for commit 825334b. ± Comparison against base commit a372a8c. ♻️ This comment has been updated with latest results. |
655204f to
e25e5b0
Compare
e25e5b0 to
c2d7645
Compare
c2d7645 to
62ddc9c
Compare
|
Removals are best done for M1 and not M3 |
The org.eclipse.core.runtime.contentTypes extension point is being removed in eclipse-platform/eclipse.platform#1644. Update the two remaining test fixtures (regression test for bug 107121 in OpenNavigatorFolderTest, and ObjectContributionTest) to contribute to org.eclipse.core.contenttype.contentTypes instead.
The org.eclipse.core.runtime.contentTypes extension point was removed in eclipse-platform/eclipse.platform#1644. Update schema documentation to reference the non-deprecated org.eclipse.core.contenttype.contentTypes extension point instead.
4991a2f to
9dc9b77
Compare
0ed4a22 to
c12b524
Compare
|
I assume we don’t need two version increment commits. |
In 2018 we marked this extension point for deletion, lets remove it.
c12b524 to
825334b
Compare
|
Failing test requires that I remove ISV doc references to the soon deleted org.eclipse.core.runtime.contentTypes extension point. The bundle actually lives in the eclipse.platform.releng.aggregator repo, not eclipse.platform.ui |
|
Follow-up after this is merged: org.eclipse.core.contenttype ContentTypeBuilder.getConfigurationElements() explicitly reads both points (lines 243–245 fetch the old org.eclipse.core.runtime.contentTypes). Once the point declaration is gone, registry.getExtensionPoint(...) returns null there, so that branch becomes dead code. |
Planned for 4.41
In 2018 we marked this extension point for deletion, lets remove it for 2025-03.